fix(editors): scope Monaco editor instance and add shallow equality to Zustand selectors (#782)#844
Closed
rupeshca007 wants to merge 3 commits intoaccordproject:mainfrom
Conversation
✅ Deploy Preview for ap-template-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Rupesh <rupeshkuneed@gmail.com>
…o Zustand selectors (accordproject#782) Bug 1 - Race Condition Fix: - Replace getModels()?.[0] with scoped useRef in ConcertoEditor.tsx - Error markers now correctly attach to the Concerto editor only Bug 2 - Performance Fix: - Add shallow equality from zustand/shallow to all object-returning Zustand selectors across 9 components - Prevents unnecessary re-renders on every keystroke Files modified: - src/editors/ConcertoEditor.tsx (both fixes) - src/App.tsx - src/editors/JSONEditor.tsx - src/editors/MarkdownEditor.tsx - src/components/PlaygroundSidebar.tsx - src/components/ProblemPanel.tsx - src/components/AIConfigPopup.tsx - src/components/AIChatPanel.tsx - src/components/CodeSelectionMenu.tsx Signed-off-by: Rupesh <rupeshkuneed@gmail.com>
rupeshca007
force-pushed
the
fix/782-monaco-race-condition-and-zustand-perf
branch
from
e1d4c76 to
0021e1d
Compare
Author
|
Hi @accordproject/maintainers Could you please approve the CI workflows to run? I've also fixed the DCO sign-off. Thank you for your time! |
|
This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #782 - Syntax error markers attach to wrong editor instances due to global model indexing
Changes
Bug 1: Race Condition Fix (ConcertoEditor.tsx)
Bug 2: Performance Fix (9 files)
Files modified:
Testing